Differential D14582

[effects/fade] Don't animate the logout screen
ClosedPublic
Actions

Authored by zzag on Aug 3 2018, 3:35 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Plasma
Commits
R108:d61f3ec2d537: [effects/fade] Don't animate the logout screen
Summary

The appearing of the logout screen is animated by both the Fade effect
and the Logout effect. The former should not animate the logout screen
because that's the job of the latter.

Test Plan

Clicked the shut down button, the log out screen smoothly faded in.
Clicked the cancel button, the log out screen instantaneously disappeared.

Diff Detail

Repository
R108 KWin
Branch
effects-fade-dont-animate-logout-screen
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1491
Build 1509: arc lint + arc unit
zzag created this revision.Aug 3 2018, 3:35 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 3 2018, 3:35 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 3 2018, 3:35 PM
zzag added a comment.Aug 3 2018, 3:37 PM

Should the Logout effect animate the disappearing of the logut screen?

davidedmundson accepted this revision.Aug 4 2018, 6:06 PM
davidedmundson added a subscriber: davidedmundson.

add a comment about why they're blacklisted (that they conflict with login/logout effects)

This revision is now accepted and ready to land.Aug 4 2018, 6:06 PM
zzag added a comment.Aug 5 2018, 8:57 AM
In D14582#303412, @davidedmundson wrote:

add a comment about why they're blacklisted (that they conflict with login/logout effects)

OK, will do it.

zzag closed this revision.Aug 5 2018, 9:05 AM

Revision Contents
Changeset List

Diff 39023

View Options

effects/fade/package/contents/code/main.js

Loading...