They were missing in a couple of places leading to crashes.
Details
Details
- Reviewers
- None
- Group Reviewers
Plasma - Commits
- R120:79ac08108966: [Desktop Scripting ConfigGroup] Add more nullptr checks
Ran the following script
print(new ConfigFile().groupList);
Used to crash, now it no longer does
Despite the qjsengine port, this file didn't change in 5.12, so should be easily backportable
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
shell/scripting/configgroup.cpp | ||
---|---|---|
67 | Here as well should be sync(), if it destroys object before timer is elapsed e.g. before 1.5 sec it will crash. |
Comment Actions
I didn't write that code, I noticed a crash that was trivially fixed and did just that