Differential D14572

Check the build directory for po/ as well
ClosedPublic
Actions

Authored by apol on Aug 3 2018, 12:12 AM.

Details

Reviewers
ltoscano
dfaure
Group Reviewers
Frameworks
Commits
R249:64796250e69d: Check the build directory for po/ as well
Summary

Instead of just checking if it's in the source directory, check in the
build directory as well, as ECM can download po/ there as well.

Test Plan

Built KAlgebra translations using the Android docker SDK

Diff Detail

Repository
R249 KI18n
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Aug 3 2018, 12:12 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 3 2018, 12:12 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Aug 3 2018, 12:12 AM
dfaure accepted this revision.Aug 4 2018, 10:33 AM
dfaure added a subscriber: dfaure.
dfaure added inline comments.
cmake/KF5I18nMacros.cmake.in
111

For symmetry add a comment to this line too, then? Something like:

# First try to find the po directory in the source directory, where the release scripts copy them before making the tarballs
This revision is now accepted and ready to land.Aug 4 2018, 10:33 AM
apol updated this revision to Diff 39196.Aug 6 2018, 2:17 PM

Added David's recommended comment

ltoscano accepted this revision.Aug 6 2018, 2:21 PM

It was basically already approved, and it already made sense. The only requested change (a comment) was applied.

dfaure accepted this revision.Aug 6 2018, 9:26 PM
Closed by commit R249:64796250e69d: Check the build directory for po/ as well (authored by apol). · Explain WhyAug 6 2018, 10:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcmake/KF5I18nMacros.cmake.in (77 lines)

Diff 39233

View Options

cmake/KF5I18nMacros.cmake.in

Loading...