Differential D14530

Fix crash when save a QImage to the eps format file
AbandonedPublic
Actions

Authored by kossebau on Aug 1 2018, 6:27 AM.

Details

Reviewers
mlaurent
dfaure
zccrs
Summary

fix the bug: https://bugs.kde.org/show_bug.cgi?id=397040

Diff Detail

Repository
R287 KImageFormats
Lint
Lint Skipped
Unit
Unit Tests Skipped
zccrs created this revision.Aug 1 2018, 6:27 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 1 2018, 6:27 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zccrs requested review of this revision.Aug 1 2018, 6:27 AM
dfaure requested changes to this revision.Aug 1 2018, 6:55 AM

I don't see much point in this patch, Qt already tells you that a QCoreApplication is missing (as you can see in the bug report). You have to create a QCoreApplication in any Qt process, that's a fact, we're not going to remind the developer before each and every use of a Qt class.

This revision now requires changes to proceed.Aug 1 2018, 6:55 AM
zccrs added a comment.EditedAug 7 2018, 1:47 AM
In D14530#301690, @dfaure wrote:

I don't see much point in this patch, Qt already tells you that a QCoreApplication is missing (as you can see in the bug report). You have to create a QCoreApplication in any Qt process, that's a fact, we're not going to remind the developer before each and every use of a Qt class.

Hi, I was replied in https://bugs.kde.org/show_bug.cgi?id=397040. I hope to get a reply. Thank you

kossebau added a comment.Sep 10 2018, 12:55 PM

Given this here still shows up in my phabricator list, and having given "smart" ;) comments on the bug report, please find a patch based on my comments at D15405.

kossebau added a comment.Sep 23 2018, 12:04 PM

@zccrs Hi. Does D15405 fix things for you, so is this patch here no longer needed? If so, please close this review request by selecting and submitting the action "Abandon Revision", so it does no longer appear in our "Please review" list :)

kossebau commandeered this revision.Oct 8 2018, 11:09 PM
kossebau edited reviewers, added: zccrs; removed: kossebau.
kossebau abandoned this revision.Oct 8 2018, 11:12 PM

Closing this review request as the author has not reacted. D15405 should be serving already as more proper fix for the referenced bug.

Revision Contents
Changeset List

PathPackages
Msrc/imageformats/eps.cpp (7 lines)

Diff 38889

View Options

src/imageformats/eps.cpp

Loading...