Fix naming: closable not closeable
AbandonedPublic

Authored by graesslin on Apr 19 2016, 11:03 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Summary

All incorrect named methods are deprecated. In the interface it's just
renamed, it's just an internal enum value not exposed to outside world.

Diff Detail

Repository
R127 KWayland
Branch
closeable-becomes-closable
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 3413.Apr 19 2016, 11:03 AM
graesslin retitled this revision from to Fix naming: closable not closeable.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma, hein.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 19 2016, 11:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas added a subscriber: sebas.Apr 19 2016, 11:33 AM

http://www.collinsdictionary.com/dictionary/english/closeable suggests that both, closable and closeable are correct.
http://www.oxforddictionaries.com/definition/english/close?q=closable#close-2__50 says only closable is correct.
http://www.googlefight.com/closeable-vs-closable.php is of course the real metric, and says closable is preferred.

I'd leave it as is since it's not 100% clear in this situation, and at that point it's just semantic wankery to add grammatically correct API.

hein edited edge metadata.Apr 19 2016, 11:38 AM

Martin decided to change it to closable in kwayland; he's prepped changes to add new versions and deprecate the old ones, once that's in I will update this revision to follow suit.

hein added a comment.Apr 19 2016, 11:39 AM

Arf, sorry - I confused this with D1435.

graesslin abandoned this revision.Apr 21 2016, 10:39 AM