Add missing data role for closable state.
ClosedPublic

Authored by hein on Apr 17 2016, 2:49 PM.

Details

Summary

Exposes closable state in the window model and adds tests. This was
included in the protocol and interface, but missing from the model.

NOTE: I decided to call this one "Closeable" because that's what it was already called in kwayland, however the e/no-e mess is getting worse and there's no hope for fixing it because we have different styles in API-stable code already. I'd prefer to do the right thing for any added lines of code, which to me is naming it "Closable".

Martin, I think you need to make a maintainer's decision on this
(doesn't matter which, as long as we pick one) to allow all of
these revisions to progress.

Test Plan

Autotest extended.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein updated this revision to Diff 3388.Apr 17 2016, 2:49 PM
hein retitled this revision from to Add missing data role for closable state..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added a reviewer: graesslin.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 17 2016, 2:49 PM
graesslin edited edge metadata.Apr 18 2016, 5:22 AM

I'm not doing a maintainer decision, but delegate this to a native speaker.

mart accepted this revision.Apr 19 2016, 7:58 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Apr 19 2016, 7:58 AM
graesslin accepted this revision.Apr 21 2016, 10:39 AM
graesslin edited edge metadata.
This revision was automatically updated to reflect the committed changes.