Differential D14445

Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH
ClosedPublic
Actions

Authored by shlomif on Jul 28 2018, 5:29 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Commits
R410:fdbb63304b9d: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH

Diff Detail

Repository
R410 KPatience
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shlomif created this revision.Jul 28 2018, 5:29 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptJul 28 2018, 5:29 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
shlomif requested review of this revision.Jul 28 2018, 5:29 PM
shlomif updated this revision to Diff 44494.Oct 30 2018, 3:09 PM
  • Include prefix was restored in v5.0.0 of fcs.
shlomif updated this revision to Diff 44495.Oct 30 2018, 3:14 PM

Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH .

See https://fc-solve.shlomifish.org/#news-2018-10-27 .

aacid added a subscriber: aacid.Oct 30 2018, 7:21 PM

Will this still work with 4.x ?

shlomif added a comment.Oct 31 2018, 9:41 AM
In D14445#351109, @aacid wrote:

Will this still work with 4.x ?

I believe that neither the current git version nor the version patched with the current patch will compile with a Freecell Solver 4.x.y version if it is under a prefix and specified in $PKG_CONFIG_PATH. The current patch should improve matters though.

aacid accepted this revision.Oct 31 2018, 8:31 PM
This revision is now accepted and ready to land.Oct 31 2018, 8:31 PM
Closed by commit R410:fdbb63304b9d: Fix the libfreecell-solver headers if using $PKG_CONFIG_PATH (authored by shlomif). · Explain WhyNov 3 2018, 6:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 44793

View Options

CMakeLists.txt

Loading...