Differential D14350

Make sure for loop does not detach
ClosedPublic
Actions

Authored by gladhorn on Jul 25 2018, 6:50 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R110:7cbccda5a273: Make sure for loop does not detach

Diff Detail

Repository
R110 KScreen Library
Branch
arcpatch-D14350
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1178
Build 1191: arc lint + arc unit
gladhorn created this revision.Jul 25 2018, 6:50 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 6:50 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 25 2018, 6:50 AM
broulik added a subscriber: broulik.Jul 25 2018, 9:39 AM
broulik added inline comments.
src/config.cpp
371–372

This still calls config->outputs().begin() and might detach, wouldn't it?
qAsConst also doesn't work for return value of a method call, so looks like you're gonna have to store it in a const variable first

gladhorn updated this revision to Diff 38426.Jul 25 2018, 1:54 PM

Use a temporary const for ranged for

davidedmundson accepted this revision.Jul 27 2018, 10:14 AM
This revision is now accepted and ready to land.Jul 27 2018, 10:14 AM
Closed by commit R110:7cbccda5a273: Make sure for loop does not detach (authored by gladhorn). · Explain WhyJul 27 2018, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/config.cpp (3 lines)

Diff 38426

View Options

src/config.cpp

Loading...