Differential D14341

if an applet is invalid, it has immediately UiReadyConstraint
ClosedPublic
Actions

Authored by mart on Jul 24 2018, 7:10 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:56f0df412713: if an applet is invalid, it has immediately UiReadyConstraint
Summary

mirroring the behavior when the applet is created by restorecontents,
invalid applets get immediately uireadyconstraint.
This solves the problem of panels not appearing when the setup js contains an non existent applet,
as the panel was waiting forever for applets to finish loading, which never happens

Test Plan

now js startup scripts with an invalid applet have panels loading correctly.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Jul 24 2018, 7:10 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 24 2018, 7:10 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Jul 24 2018, 7:10 PM
davidedmundson accepted this revision.Jul 26 2018, 11:05 AM
davidedmundson added a subscriber: davidedmundson.

you have typos in the comment and commit message

This revision is now accepted and ready to land.Jul 26 2018, 11:05 AM
mart edited the summary of this revision. (Show Details)Jul 26 2018, 11:09 AM
Closed by commit R242:56f0df412713: if an applet is invalid, it has immediately UiReadyConstraint (authored by mart). · Explain WhyJul 26 2018, 11:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38497

View Options

src/plasma/private/containment_p.cpp

Loading...