[Multimedia KCM] Kill PulseAudio device setup
ClosedPublic
Actions

Authored by broulik on Jul 24 2018, 6:45 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

It is redundant with plasma-pa

Test Plan

(I wish we could just kill this entire thing)

The KCM is defunct here as I don't have any backends.. but the tab is completely gone and compiles

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jul 24 2018, 6:45 PM

Looks like we had the same thought again :D D13935

nicolasfella added a reviewer: sitter.

👍

Awesome work on the plasma-pa side too!

This revision is now accepted and ready to land.Jul 26 2018, 10:59 AM

This revision was automatically updated to reflect the committed changes.

		Path
D	M	cmake/modules/FindCanberra.cmake (50 lines)
D	M	kcms/colors/colors.desktop (194 lines)
M		kcms/phonon/CMakeLists.txt (31 lines)
D	M	kcms/phonon/audiosetup.h (98 lines)
D	M	kcms/phonon/audiosetup.cpp (884 lines)
D	M	kcms/phonon/audiosetup.ui (224 lines)
M		kcms/phonon/main.h (11 lines)
M		kcms/phonon/main.cpp (18 lines)
D	M	kcms/phonon/testspeakerwidget.h (52 lines)
D	M	kcms/phonon/testspeakerwidget.cpp (203 lines)