Differential D14336

Make calendar Plasma plugin JSON consistent with other plugins and translatable
AbandonedPublic
Actions

Authored by yurchor on Jul 24 2018, 2:57 PM.

Details

Reviewers
mck182
Group Reviewers
Plasma
Localization
Summary

Currently, JSON file has a structure which is not parsed by the scripty. The patch tries to fix this.

Test Plan
  1. Use of "python <some_dir>/createjsoncontext.py find . -name \*.json ./po" where <some_dir> is a clone of this dir: https://websvn.kde.org/trunk/l10n-kf5/scripts/ should extract messages from holidayeventsplugin.json (tested)
  2. The plugin should work (not tested)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
yurchor created this revision.Jul 24 2018, 2:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 24 2018, 2:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
yurchor requested review of this revision.Jul 24 2018, 2:57 PM
kossebau added a subscriber: kossebau.Jul 24 2018, 3:06 PM

See https://phabricator.kde.org/D14335#297096 might need other changes to the plugin to make it a real kplugin format.

yurchor abandoned this revision.Aug 13 2018, 5:08 PM

Revision Contents
Changeset List

Diff 38344

View Options

plasmacalendarintegration/holidayeventsplugin.json

Loading...