Currently, JSON file has a structure which is not parsed by the scripty. The patch tries to fix this.
Details
Details
- Reviewers
kossebau - Group Reviewers
Plasma Localization
- Use of "python <some_dir>/createjsoncontext.py find . -name \*.json ./po" where <some_dir> is a clone of this dir: https://websvn.kde.org/trunk/l10n-kf5/scripts/ should extract messages from astronomicaleventsplugin.json (tested)
- The plugin should work (not tested)
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Adding @kossebau with the question: is there a reason to not have the KPlugin key in the json file?
Comment Actions
TD;LR current legacy-based implementation might need that format. Needs complete tested porting to KPlugin.
I had blindly copying the only other-known-to-me existing plugin data, which also has that metadata schema.
Cmp. also https://phabricator.kde.org/source/plasma-workspace/browse/master/plasmacalendarintegration/holidayeventsplugin.json
Looking at https://phabricator.kde.org/source/plasma-framework/browse/master/src/declarativeimports/calendar/eventpluginsmanager.cpp$136 I see now that this is some legacy schema, and one could also use kplugin-based metadata. Might need some other changes to the plugin, like changing the IID. Can have a look later this week.
But grepping for *.json makes my MIME/Media type heart bleed. Someone(tm) should introduce a proper file suffix (e.g. .kplugindata) for those specific schema.
We also use .cpp for C++ sources, despite the base format being plain text (.txt).