After workaround for https://bugs.kde.org/show_bug.cgi?id=393779 clangsupport plugin
on FreeBSD got broken completely. In https://phabricator.kde.org/D13613 it was agreed
that using cpuid.h header to detect Clang's built-in directory is a bit better hack.
Details
Details
- Reviewers
pino mwolff - Group Reviewers
KDevelop - Commits
- R32:9f1fd725f39d: Fix clangsupport on FreeBSD.
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
plugins/clang/clangsupport.cpp | ||
---|---|---|
182 | If you change this i18n message, then replace the file with a new placeholder (%2), adding the header as argument: this way, if in the future it needs to be changed again, the message will not require any change. |
plugins/clang/clangsupport.cpp | ||
---|---|---|
181–183 | Most probably this variable should not start with /. |
plugins/clang/clangsupport.cpp | ||
---|---|---|
181–183 | This would make the code a bit uglier at the cost of a bit prettier message. Can do, if you insist. |
plugins/clang/clangsupport.cpp | ||
---|---|---|
181–183 | I don't see how QFile::exists(builtinDir + QLatin1String("/") + headerToCheck) would be uglier (which is something highly subjective). |
Comment Actions
either implement pinos variant or keep the old code and change the header name in two places