Differential D14309

Handling multiple occurrence of the same sequence job corrected
AbandonedPublic
Actions

Authored by mutlaqja on Jul 23 2018, 7:02 PM.

Details

Reviewers
wreissenberger
Summary

Capture may handle now multiple occurences of the same sequence
job correctly - e.g. RGBLRGB.

  • Update --

Review comments of Eric incorporated.

BUG: 396742

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1099
Build 1112: arc lint + arc unit
wreissenberger requested review of this revision.Jul 23 2018, 7:02 PM
wreissenberger created this revision.
mutlaqja commandeered this revision.Jul 25 2018, 8:08 AM
mutlaqja added a reviewer: wreissenberger.
mutlaqja added a subscriber: mutlaqja.

This one still fails to patch against KStars master

TallFurryMan added a subscriber: TallFurryMan.Jul 25 2018, 8:11 AM

Good to go, but apparently we need to patch with D14280 first?

kstars/ekos/capture/capture.cpp
2741

Just init result to -1 to get rid of the test?

kstars/ekos/capture/capture.h
612

This is an unexpected addition.

wreissenberger added a comment.Jul 25 2018, 7:04 PM

It seems like this patch is not in the current master of 2.9.7. The code I found in capture.cpp looks like https://phabricator.kde.org/D14280 and not the corrected version from https://phabricator.kde.org/D14309.

Sorry for the confusion, but this is the first time I use arc...

TallFurryMan added a comment.Jul 26 2018, 12:13 PM

I confirm I see D14357 in git, and that D14357 seems to match D14309.
The only thing I did is sequencing D14280 and D14309 to create D14357, so that the resulting differential may apply properly onto branch master.
Any specific concerns I missed?

wreissenberger added a comment.Aug 4 2018, 2:56 PM

I made a small correction in the log output: https://phabricator.kde.org/D14605

Please advise: is this the correct way to submit changes?

mutlaqja abandoned this revision.Aug 8 2018, 5:37 AM

Revision Contents
Changeset List

Diff 38272

View Options

kstars/ekos/capture/capture.h

Loading...
View Options

kstars/ekos/capture/capture.cpp

Loading...