Differential D14290

[KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid
AbandonedPublic
Actions

Authored by broulik on Jul 23 2018, 9:18 AM.

Details

Reviewers
dfaure
Summary

It checks whether the file is not in TEMP but it doesn't check whether the QUrl is valid.
It opens destination when you click the button which fails when it is invalid/empty.

CCBUG: 396738

Test Plan

Buttons no longer show when there is no destination

Diff Detail

Repository
R288 KJobWidgets
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 23 2018, 9:18 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 23 2018, 9:18 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jul 23 2018, 9:18 AM
dfaure added a comment.Jul 30 2018, 7:36 PM

Why is this called with an invalid URL?

The bug report says "copy/move a big file to another device/partition." -- surely the destination should be valid? It sounds like this patch is masking a real bug...

dfaure requested changes to this revision.Jul 30 2018, 7:36 PM
This revision now requires changes to proceed.Jul 30 2018, 7:36 PM
broulik abandoned this revision.Apr 9 2019, 6:46 PM

Revision Contents
Changeset List

PathPackages
Msrc/kwidgetjobtracker.cpp (2 lines)

Diff 38230

View Options

src/kwidgetjobtracker.cpp

Loading...