Differential D14275

Add Autodesk EAGLE sch and brd file format to the XML category
ClosedPublic
Actions

Authored by martonmiklos on Jul 22 2018, 2:36 PM.

Details

Reviewers
dhaumann
Group Reviewers
Framework: Syntax Highlighting
Summary

The Autodesk EAGLE uses plain XML format since a few years, and I think it would be useful to load the proper syntax highlighting in Kate automatically.

Test Plan

Create an XML file.
Rename it to foo.sch
Open it in kate
The syntax highlighting should be OK.
Rename the foo.sch to foo.brd
Open it in kate
The syntax highlighting should be OK.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
martonmiklos created this revision.Jul 22 2018, 2:36 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJul 22 2018, 2:36 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
martonmiklos requested review of this revision.Jul 22 2018, 2:36 PM
dhaumann accepted this revision.Jul 22 2018, 10:49 PM
dhaumann added a subscriber: dhaumann.

Looks good to me, but we also have to increase the 'version' number from 7 to 8.

This revision is now accepted and ready to land.Jul 22 2018, 10:49 PM
martonmiklos updated this revision to Diff 38273.Jul 23 2018, 7:05 PM

Updated revision to 8 from 7 as suggested in the review.

cullmann closed this revision.Aug 13 2018, 8:22 AM
cullmann added a subscriber: cullmann.

Git commit 106694b84c2baf2aa390dc17107912f0eb16f09c by Christoph Cullmann, on behalf of Miklos Marton.
Committed on 13/08/2018 at 08:21.
Pushed by cullmann into branch 'master'.

Add Autodesk EAGLE sch and brd file format to the XML category

M +1 -1 data/syntax/xml.xml

https://commits.kde.org/syntax-highlighting/106694b84c2baf2aa390dc17107912f0eb16f09c

diff --git a/data/syntax/xml.xml b/data/syntax/xml.xml
index 035bba6..ad34a45 100644

  • a/data/syntax/xml.xml

+++ b/data/syntax/xml.xml
@@ -6,7 +6,7 @@

<!ENTITY name    "(?![0-9])[\w_:][\w.:_-]*">
<!ENTITY entref  "&amp;(#[0-9]+|#[xX][0-9A-Fa-f]+|&name;">

]>
-<language name="XML" version="8" kateversion="3.4" section="Markup" extensions="*.docbook;*.xml;*.rc;*.daml;*.rdf;*.rss;*.xspf;*.xsd;*.svg;*.ui;*.kcfg;*.qrc;*.wsdl;*.scxml;*.xbel;*.dae" mimetype="text/xml;text/book;text/daml;text/rdf;application/rss+xml;application/xspf+xml;image/svg+xml;application/x-designer;application/x-xbel;application/xml;application/scxml+xml" casesensitive="1" indenter="xml" author="Wilbert Berendsen (wilbert@kde.nl)" license="LGPL">
+<language name="XML" version="9" kateversion="3.4" section="Markup" extensions="*.docbook;*.xml;*.rc;*.daml;*.rdf;*.rss;*.xspf;*.xsd;*.svg;*.ui;*.kcfg;*.qrc;*.wsdl;*.scxml;*.xbel;*.dae;*.sch;*.brd" mimetype="text/xml;text/book;text/daml;text/rdf;application/rss+xml;application/xspf+xml;image/svg+xml;application/x-designer;application/x-xbel;application/xml;application/scxml+xml" casesensitive="1" indenter="xml" author="Wilbert Berendsen (wilbert@kde.nl)" license="LGPL">

Revision Contents
Changeset List

PathPackages
Mdata/syntax/xml.xml (2 lines)

Diff 38273

View Options

data/syntax/xml.xml

Loading...