Differential D14211

Collapsible Sidebar Mode
ClosedPublic
Actions

Authored by mart on Jul 18 2018, 3:12 PM.

Details

Reviewers
apol
Group Reviewers
Kirigami
Commits
R169:6b887b056ce6: Collapsible Sidebar Mode
Summary

This adds a new mode for OverlayDrawer, mostly for GlobalDrawer but applications can implement their own collapsing visuals in an OverlayDrawer. It is a Desktop-only feature.

NOTE: this is explicitly and only for drawers: it is NOT intended for content which semantically should be in a Page in the main PageRow: if needed there similar such behavior should be implemented for the Page and the PageRow's defaultColumnWidth instead.

a new property called "collapsible" controls wether the drawer supports the collapsed mode.

NOTE: It is not supported neither in mobile mode nor on modal, overlay drawers

the property "collapsed" controls whether the drawer is collapsed or not

NOTE: it's supported only in "collapsible" mode
Test Plan

tested in the gallery app

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Jul 18 2018, 3:12 PM
mart created this object with visibility "No One".
Restricted Application added a project: Kirigami. · View Herald TranscriptJul 18 2018, 3:12 PM
mart requested review of this revision.Jul 18 2018, 3:12 PM
mart updated this revision to Diff 38025.Jul 18 2018, 3:13 PM
  • first rough prototype of collapsible sidebar
  • throw in some animations
  • use a single view for collapsed and full mode
  • fix popup position
  • Merge branch 'master' into mart/collasibleSidebar
  • slightly bigger toolbar
  • layout fixes
  • better menus behavior
  • move properties to overlaydrawer
  • forbid collapsible on modal
  • can be controlled whether hide top and bottom contents
  • fix fading of main content
  • fully move resizing logic to OverlayDrawer
  • more comments
  • fix handle in RTL mode
  • Merge branch 'master' into mart/collasibleSidebar
mart retitled this revision from blah to Collapsible Sidebar Mode.Jul 18 2018, 3:26 PM
mart edited the summary of this revision. (Show Details)
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Kirigami.
mart added a comment.Jul 18 2018, 3:29 PM

vokoscreen-2018-07-18_17-27-35.mkv600 KBDownload

mart changed the visibility from "No One" to "Public (No Login Required)".Jul 18 2018, 3:29 PM
mart added a project: VDG.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJul 18 2018, 3:29 PM
apol requested changes to this revision.Jul 25 2018, 12:56 PM
apol added a subscriber: apol.
apol added inline comments.
src/controls/GlobalDrawer.qml
188 ↗(On Diff #38025)

The documentation says "show" and actually it kind of makes sense.
Same with the property below.

This revision now requires changes to proceed.Jul 25 2018, 12:56 PM
This revision was not accepted when it landed; it landed in state Needs Revision.Jul 25 2018, 12:59 PM
Closed by commit R169:6b887b056ce6: Collapsible Sidebar Mode (authored by mart). · Explain Why
This revision was automatically updated to reflect the committed changes.
mart added inline comments.Jul 25 2018, 1:08 PM
src/controls/GlobalDrawer.qml
188 ↗(On Diff #38025)

corrected and flipped back to show in the landed version

Showing Only Differences

This revision modifies 6 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/controls/GlobalDrawer.qml (208 lines)

Diff 38418

View Options

src/controls/GlobalDrawer.qml

Loading...