Fix the configure check for _nl_msg_cat_cntr
ClosedPublic
Actions

Authored by vkrause on Jul 17 2018, 5:15 PM.

Details

Reviewers

Commits

Summary

We need to pass -Wl,--no-undefined to the linker for this to fail when the
symbol isn't present, otherwise this always passes.

This fixes the build on Android, where this symbol doesn't exist.

Repository

R249 KI18n

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

vkrause requested review of this revision.Jul 17 2018, 5:15 PM

Thanks! Had to workaround this earlier today.

This revision is now accepted and ready to land.Jul 17 2018, 11:17 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			cmake/FindLibIntl.cmake (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37975	608a6af		Jul 17 2018, 5:15 PM	★	★
Diff 2	37990	6342a24	R249:7afa19b90921cc4f97631fef74c729e9f82a274b	Jul 18 2018, 7:28 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6649d123ecd4	0ab318a6bdd1	608a6afbcbd8	Volker Krause	Fix the configure check for _nl_msg_cat_cntr (Show More…)	Jul 17 2018, 5:15 PM