Android: Fix small build issues
ClosedPublic

Authored by apol on Jul 17 2018, 2:45 PM.

Details

Summary

KDocTools isn't necessary for kstars_lite
Make sure we error when building on a system that doesn't have dos2unix,
makes finding what to do easier.
Prefer checking if we're on android using __ANDROID__ which is the one
defined by the NDK. See
/opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -E -dM - < /dev/null | grep -i android
Define strings as QStrings, newer ki18n chokes on literals.
Use qRound instead of std::round, just works, maybe it needed to add an

Test Plan

Built it with KDE's binary-factory docker image, if this lands we'll get to include kstars in the nightly builds.

Diff Detail

Repository
R321 KStars
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 952
Build 965: arc lint + arc unit
apol created this revision.Jul 17 2018, 2:45 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 17 2018, 2:45 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
apol requested review of this revision.Jul 17 2018, 2:45 PM
apol edited the summary of this revision. (Show Details)Jul 17 2018, 3:51 PM
apol edited the summary of this revision. (Show Details)
This comment was removed by mutlaqja.
ckertesz accepted this revision.Jul 18 2018, 10:58 AM

I think the changes are fine. You can merge this patch.

This revision is now accepted and ready to land.Jul 18 2018, 10:58 AM
This revision was automatically updated to reflect the committed changes.