Differential D14187

Fix variable definition check
ClosedPublic
Actions

Authored by apol on Jul 17 2018, 2:38 PM.

Details

Reviewers
vkrause
Group Reviewers
Frameworks
Commits
R240:17158129a853: Fix variable definition check
Summary

We'd check if the variable's value is defined, which is wrong and prevented us
from properly initialising using these deprecated variables.
It would also ignore the value we're passing to the actually right variable when
using it.

Test Plan

Built kstars which needs -DCMAKE_ANDROID_API=24

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 17 2018, 2:38 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJul 17 2018, 2:38 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jul 17 2018, 2:38 PM
vkrause accepted this revision.Jul 17 2018, 5:47 PM
This revision is now accepted and ready to land.Jul 17 2018, 5:47 PM
Closed by commit R240:17158129a853: Fix variable definition check (authored by apol). · Explain WhyJul 17 2018, 11:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtoolchain/Android.cmake (2 lines)

Diff 37987

View Options

toolchain/Android.cmake

Loading...