Reduce unnecessary long wait times on failing signal spies
ClosedPublic

Authored by romangg on Jul 17 2018, 12:10 PM.

Details

Summary

Several signal spies, which were supposed to fail, were waiting for the
default 5 seconds, which is most often unnecessary long.

This patch sets a time limit of 500ms in suitable cases. Reduces for me
the total test time by 40%.

Test Plan

Before (with fixed seat and selection tests):
98% tests passed, 1 tests failed out of 45

Total Test time (real) = 173.31 sec

The following tests FAILED:

19 - kwayland-testWindowmanagement (Failed)

After:
98% tests passed, 1 tests failed out of 45

Total Test time (real) = 102.12 sec

The following tests FAILED:

19 - kwayland-testWindowmanagement (Failed)

Diff Detail

Repository
R127 KWayland
Branch
autotestsWaits
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 946
Build 959: arc lint + arc unit
romangg created this revision.Jul 17 2018, 12:10 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 17 2018, 12:10 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
romangg requested review of this revision.Jul 17 2018, 12:10 PM
davidedmundson accepted this revision.Jul 17 2018, 1:15 PM
This revision is now accepted and ready to land.Jul 17 2018, 1:15 PM
This revision was automatically updated to reflect the committed changes.