Differential D14152

Remove ref from returned QString
ClosedPublic
Actions

Authored by gladhorn on Jul 16 2018, 7:51 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R104:97f7b9cff782: Remove ref from returned QString
Summary

Let's leave it up to the compiler to eliminate the ref.
Suggested by zzag.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 16 2018, 7:51 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 16 2018, 7:51 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 16 2018, 7:51 AM
zzag added a subscriber: zzag.Jul 16 2018, 7:52 AM
zzag added inline comments.
kded/osd.cpp
58

Please keep const.

gladhorn updated this revision to Diff 37922.Jul 17 2018, 5:30 AM

Re-added the const

davidedmundson accepted this revision.Jul 17 2018, 8:48 AM
This revision is now accepted and ready to land.Jul 17 2018, 8:48 AM
Closed by commit R104:97f7b9cff782: Remove ref from returned QString (authored by gladhorn). · Explain WhyJul 17 2018, 7:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/osd.cpp (2 lines)

Diff 37983

View Options

kded/osd.cpp

Loading...