Fix selecting a favorite that is filtered out in the foldertreeview.
ClosedPublic

Authored by dfaure on Jul 15 2018, 5:09 PM.

Details

Summary

Adapt to the messagelib commit that requires a modelindex in
Pane::setCurrentFolder.

Also avoid calling setCurrentFolder twice when selecting a favorite
(once because the favorite selection changed, and once again because the
foldertreeview selection changed). This issue was pre-existing but
wasn't visible because it didn't populate the messagelist or created new
tabs.

Test Plan

Diff Detail

Repository
R206 KMail
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 947
Build 960: arc lint + arc unit
dfaure created this revision.Jul 15 2018, 5:09 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 15 2018, 5:09 PM
Restricted Application edited subscribers, added: kde-pim; removed: KDE PIM. · View Herald Transcript
dfaure requested review of this revision.Jul 15 2018, 5:09 PM
dfaure updated this revision to Diff 37823.Jul 15 2018, 5:12 PM

Fix "jump to folder" in case the target folder is filtered out

dfaure updated this revision to Diff 37949.Jul 17 2018, 12:47 PM

Rebase to master; require messagelib 5.8.81

mlaurent accepted this revision.Jul 17 2018, 12:59 PM
This revision is now accepted and ready to land.Jul 17 2018, 12:59 PM
This revision was automatically updated to reflect the committed changes.