Improve "Remove this [widget]" text
AbandonedPublic

Authored by ngraham on Jul 14 2018, 9:13 PM.

Details

Reviewers
gladhorn
Group Reviewers
Plasma
VDG
Summary

This patch adds the word "widget" onto the end of the string that's currently "Remove this [widget]", which yields the following user interface improvements:

  • The string is no longer grammatically incorrect when the name of the widget is a plural noun (e.g. "Remove this Notes" vs "Remove this Notes widget")
  • Reinforces the fact that everything in Plasma is a widget, emphasizing its modularity
Test Plan

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
remove-this-widget (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1144
Build 1157: arc lint + arc unit
ngraham created this revision.Jul 14 2018, 9:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 14 2018, 9:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 14 2018, 9:13 PM
ngraham edited the test plan for this revision. (Show Details)Jul 14 2018, 9:14 PM

Ping? Is the proposed wording good enough, or should we maybe instead just remove the word "this" and make it use "Remove <widget name>?

gladhorn accepted this revision.Jul 17 2018, 7:10 PM
gladhorn added a subscriber: gladhorn.

I'd say make the casing consistent, otherwise it's a clear improvement in my opinion.

src/plasma/containment.cpp
127 ↗(On Diff #37768)

The translation help says applet, is widget or applet the better word? But actually the "add new" dialog in plasma says widget, so I'm for that for consistency reasons.

src/plasma/private/applet_p.cpp
124 ↗(On Diff #37768)

This (Widget) is upper case (above it's lower case, which I prefer a tiny bit).

This revision is now accepted and ready to land.Jul 17 2018, 7:10 PM
ngraham updated this revision to Diff 38365.Jul 25 2018, 2:52 AM

Use consistent casing

ngraham marked an inline comment as done.Jul 25 2018, 2:52 AM

Now that I look at my screenshots more closely, it seems weird to have:

Configure Notes...
Remove this Notes widget

Now I feel like they should match, and be either:

Configure Notes...
Remove Notes

or:

Configure this Notes widget...
Remove this Notes widget

Now I'm leaning towards the shorter version. Thoughts?

ngraham updated this revision to Diff 39608.Aug 13 2018, 3:20 PM

Make the text consistent