Differential D14095

Fix DownloadDialog window margins to meet general theme margins
ClosedPublic
Actions

Authored by kossebau on Jul 13 2018, 10:47 AM.

Details

Reviewers
leinir
Commits
R304:6c4fe2cf761d: Fix DownloadDialog window margins to meet general theme margins
Summary

Old code prevented the widget theme to use windowborder-specific margins for the
effective outer margins.

Test Plan

Content of Download dialog now has same margins to window border like other dialogs.

Diff Detail

Repository
R304 KNewStuff
Branch
fixdownloaddialogmarginstake2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 812
Build 825: arc lint + arc unit
kossebau created this revision.Jul 13 2018, 10:47 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 13 2018, 10:47 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Jul 13 2018, 10:47 AM
leinir accepted this revision.Jul 16 2018, 7:57 AM

In principle, this would really want to go via the designers, but at the same time it does seem that this was what was originally intended anyway. Shippit :)

This revision is now accepted and ready to land.Jul 16 2018, 7:57 AM
Closed by commit R304:6c4fe2cf761d: Fix DownloadDialog window margins to meet general theme margins (authored by kossebau). · Explain WhyJul 16 2018, 8:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/downloaddialog.cpp (5 lines)

Diff 37692

View Options

src/downloaddialog.cpp

Loading...