IncrementalSearchBox: use autoFillBackground
ClosedPublic

Authored by mglb on Jul 11 2018, 2:10 AM.

Details

Summary

Resetting the widget palette to the app main palette fixes black
background problem in short and clean way.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb created this revision.Jul 11 2018, 2:10 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 11 2018, 2:10 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
mglb requested review of this revision.Jul 11 2018, 2:10 AM
mglb edited the summary of this revision. (Show Details)Jul 11 2018, 2:15 AM
mglb added a reviewer: Konsole.
hindenburg accepted this revision.Jul 11 2018, 11:35 AM
This revision is now accepted and ready to land.Jul 11 2018, 11:35 AM
hindenburg requested changes to this revision.Jul 12 2018, 1:04 AM

I'm getting crashes when I switch to another profile (with smaller font) with the search box open - can you duplicate?

I'll check w/o this patch but I couldn't duplicate it the first time

ASSERT: "screenLine <= _screenLinesSize" in file /home/kurthindenburg/Devel/KDE/src/kde/applications/konsole/src/Screen.cpp, line 1346

This revision now requires changes to proceed.Jul 12 2018, 1:04 AM

I'm getting crashes when I switch to another profile (with smaller font) with the search box open - can you duplicate?

I'll check w/o this patch but I couldn't duplicate it the first time

ASSERT: "screenLine <= _screenLinesSize" in file /home/kurthindenburg/Devel/KDE/src/kde/applications/konsole/src/Screen.cpp, line 1346

I see that this code has a comment ; I can't see how this change could trigger it - I'll test it a bit further

// FIXME: This can be triggered when clearing history
//  while having the searchbar open and selecting next/prev
Q_ASSERT(screenLine <= _screenLinesSize);
hindenburg accepted this revision.Jul 12 2018, 1:24 AM
This revision is now accepted and ready to land.Jul 12 2018, 1:24 AM
This revision was automatically updated to reflect the committed changes.