Use non deprecated fastInsert in kio_trash
ClosedPublic

Authored by jtamate on Jul 6 2018, 8:07 AM.

Details

Summary

The entry is cleared or new before calling createUDSEntry

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jtamate created this revision.Jul 6 2018, 8:07 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 6 2018, 8:07 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
jtamate requested review of this revision.Jul 6 2018, 8:07 AM
dfaure accepted this revision.Jul 6 2018, 8:14 AM

I remember there were good reasons for not setting UDS_LOCAL_PATH in kio_trash, but by now I forgot what they were exactly :-)

I expect that some code will resolve to local paths before getting a chance to notice that it's in fact a trash url and trigger trash-specific code.
But feel free to test that, provided the testing is complete enough :)
(context menu, properties dialog, dnd for restoring, ...). That last one is a good one, we need to make sure kio_trash is involved otherwise the .trashinfo file won't get cleaned up.

This revision is now accepted and ready to land.Jul 6 2018, 8:14 AM
jtamate edited the summary of this revision. (Show Details)Jul 6 2018, 3:00 PM
This revision was automatically updated to reflect the committed changes.