Differential D13914

Avoid compiler warnings for taglib headers
ClosedPublic
Actions

Authored by kossebau on Jul 6 2018, 7:38 AM.

Details

Reviewers
mgallien
Commits
R286:90a9ff80ca3b: Avoid compiler warnings for taglib headers
Summary

Declaring them as system headers (-> -isystem) tells the compiler
we cannot do anything about them, so it stays silent for them.

Completes b680861aa2ed973eb6694a9dda1c327107323062

Test Plan

Still builds and installs, but no longer warns about issues in taglib
headers.

Diff Detail

Repository
R286 KFileMetaData
Branch
avoidtaglibheaderwarnings
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 632
Build 644: arc lint + arc unit
kossebau created this revision.Jul 6 2018, 7:38 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJul 6 2018, 7:38 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Jul 6 2018, 7:38 AM
mgallien accepted this revision.Jul 6 2018, 7:40 AM

Thanks

This revision is now accepted and ready to land.Jul 6 2018, 7:40 AM
Closed by commit R286:90a9ff80ca3b: Avoid compiler warnings for taglib headers (authored by kossebau). · Explain WhyJul 6 2018, 7:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37226

View Options

autotests/CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/writers/CMakeLists.txt

Loading...