Differential D13895

Fix off by one error in Cache::clear
ClosedPublic
Actions

Authored by davidedmundson on Jul 4 2018, 11:48 PM.

Details

Reviewers
broulik
Commits
R159:3d81d0b314f5: Fix off by one error in Cache::clear
Summary

beginRemoveRows args are int first, int last

i.e If you have 1 entry you should be calling
beginRemoveRows(0, 0);

BUG: 396175

Test Plan

Code review of a common mistake
Other usages in the same code were fine

Diff Detail

Repository
R159 KActivities Statistics
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 607
Build 619: arc lint + arc unit
davidedmundson created this revision.Jul 4 2018, 11:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 4 2018, 11:48 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jul 4 2018, 11:48 PM
broulik accepted this revision.Jul 5 2018, 8:24 AM
This revision is now accepted and ready to land.Jul 5 2018, 8:24 AM
Closed by commit R159:3d81d0b314f5: Fix off by one error in Cache::clear (authored by davidedmundson). · Explain WhyJul 5 2018, 10:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/resultmodel.cpp (2 lines)

Diff 37167

View Options

src/resultmodel.cpp

Loading...