Fix crash on post-initial refresh()

Authored by hein on Jul 2 2018, 6:40 PM.



The InvalidAppsFilterProxy and GroupSortProxy models were creating
circular parent-child relationships by setting themselves as parents
of their parent objects.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Jul 2 2018, 6:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 2 2018, 6:40 PM
hein requested review of this revision.Jul 2 2018, 6:40 PM
davidedmundson requested changes to this revision.Jul 2 2018, 9:16 PM

The parental changes totally make sense. +1 to that.

As for the reload. We shouldn't be working round KDE code. If there's a bug it should be fixed at the right place or not at all.

This revision now requires changes to proceed.Jul 2 2018, 9:16 PM
hein added a comment.Jul 2 2018, 9:22 PM

FWIW: I'm not going to make changes to this revision until the KActivitiesStats bug is fixed, which as mentioned I don't have time to fix. So this revision is stuck for now (unless I go for maintainer authority, which the situation must show).

hein updated this revision to Diff 37105.Jul 3 2018, 2:21 PM
hein retitled this revision from Work around KActivitiesStats' ResultsModel emitting wrong moves to Fix crash on post-initial refresh().
hein edited the summary of this revision. (Show Details)

Drop the hack.

davidedmundson accepted this revision.Jul 3 2018, 2:22 PM
This revision is now accepted and ready to land.Jul 3 2018, 2:22 PM
This revision was automatically updated to reflect the committed changes.