fix issues in management of the single disc property of albums
ClosedPublic
Actions

Authored by mgallien on Jun 30 2018, 8:04 AM.

Details

Reviewers

astippich
januz

Commits

R255:4ad3064bc49f: fix issues in management of the single disc property of albums

Summary

fix issues in management of the single disc property of albums

Test Plan

tests are OK including the new one

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Jun 30 2018, 8:04 AM

mgallien created this revision.

Harbormaster completed remote builds in B483: Diff 36934.Jun 30 2018, 8:04 AM

Works fine and tests pass. What was the issue here?

This revision is now accepted and ready to land.Jul 3 2018, 4:59 PM

When importing tracks, a newly created album is by default a mono disc kind of album. The code was not properly sending tracks modified signals when this property was modified for their album.

The second problem was that if an album gets its covered be modified, the code doing that was doing the wrong test (equality instead of inequality).

Closed by commit R255:4ad3064bc49f: fix issues in management of the single disc property of albums (authored by mgallien). · Explain WhyJul 3 2018, 9:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/albummodeltest.cpp (79 lines)
M			autotests/allalbumsmodeltest.cpp (73 lines)
M			autotests/allartistsmodeltest.cpp (73 lines)
M			autotests/alltracksmodeltest.cpp (73 lines)
M			autotests/alltracksproxymodeltest.cpp (73 lines)
M			autotests/databaseinterfacetest.cpp (364 lines)
M			autotests/localfilelistingtest.cpp (72 lines)
M			autotests/manageheaderbartest.h (55 lines)
M			autotests/managemediaplayercontroltest.h (71 lines)
M			autotests/mediaplaylisttest.h (72 lines)
M			autotests/mediaplaylisttest.cpp (29 lines)
M			autotests/trackslistenertest.cpp (73 lines)
M			src/databaseinterface.h (4 lines)
M			src/databaseinterface.cpp (63 lines)
M			src/musicalbum.cpp (11 lines)