Make Scheduler watch job widgets changes properly, so that setDirty is
called appropriately. Move job edition checks before job creation to
simplify the algorithm. Clarify when add button enables.
Fix wrong QT slot connections on QDoubleSpinBox.
mutlaqja |
Make Scheduler watch job widgets changes properly, so that setDirty is
called appropriately. Move job edition checks before job creation to
simplify the algorithm. Clarify when add button enables.
Fix wrong QT slot connections on QDoubleSpinBox.
Job edition in the Scheduler tab.
Jobs should properly reevaluate as they are edited, as the original
algorithm was intending to. Part of the code I removed during the past
months incorrectly assumed that there was support for canceling changes
made to a SchedulerJob.
If that feature is needed, it is relatively simple to clone a backup of
the SchedulerJob when it is opened for editing, and restore that backup
when clicking on a cancel button. However, said cancel button should not
be at the same location as the job removal button for clarity of interface.
No Linters Available |
No Unit Test Coverage |
Buildable 1479 | |
Build 1497: arc lint + arc unit |
Since you're updated Signal/Slots, may I suggest you used Qt5 new way for connection? I've been moving toward this in the code to make sure all is good at compile time. I've been bitten many times when some slots name was wrong and sent me on a goose chase to figure out what was going on. So it's like connect(someObject, &SomeClass::signal, anotherObject, &AnotherObject::function)..
Took me a while to work through the numerous overrides of connect/disconnect, but I got everything under control in the end.
kstars/ekos/scheduler/scheduler.cpp | ||
---|---|---|
416 ↗ | (On Diff #38997) | Since this is not a game nor an extremely vital warning, please do not abuse the exclamation mark. |