Differential D13736

Fix location of Info.plist file for macOS build
ClosedPublic
Actions

Authored by chrstphrchvz on Jun 26 2018, 11:21 AM.

Details

Reviewers
drosca
Group Reviewers
Falkon
Commits
R875:60b7cbd9b6b0: Fix location of Info.plist file for macOS build
Summary

Put Info.plist in src/main/ rather than src/main/main/
to prevent an error similar to the following:

CMake Error: Target falkon Info.plist template
"src/main/main/Info.plist" could not be found.

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chrstphrchvz created this revision.Jun 26 2018, 11:21 AM
Restricted Application added a project: Falkon. · View Herald TranscriptJun 26 2018, 11:21 AM
Restricted Application added a subscriber: falkon. · View Herald Transcript
chrstphrchvz requested review of this revision.Jun 26 2018, 11:21 AM
drosca accepted this revision.Jun 26 2018, 11:30 AM
drosca added a subscriber: drosca.

Do you have dev account?

This revision is now accepted and ready to land.Jun 26 2018, 11:30 AM
chrstphrchvz added a comment.Jun 26 2018, 11:56 AM
In D13736#283134, @drosca wrote:

Do you have dev account?

Nope. I'm pretty much just a Falkon user (on Linux), but had tried seeing if Falkon would work on macOS, specifically via MacPorts (cf. https://github.com/macports/macports-ports/pull/2020).

Thanks for the quick review.

rjvbb added a subscriber: rjvbb.Jun 26 2018, 6:06 PM
In D13736#283140, @chrstphrchvz wrote:
In D13736#283134, @drosca wrote:

Do you have dev account?

Nope.

I do - is there a way I can push (from here) while retaining Christopher's authorship? I've seen others do it with my patches but have no idea how.

drosca added a comment.Jun 27 2018, 1:17 PM
In D13736#283377, @rjvbb wrote:
In D13736#283140, @chrstphrchvz wrote:
In D13736#283134, @drosca wrote:

Do you have dev account?

Nope.

I do - is there a way I can push (from here) while retaining Christopher's authorship? I've seen others do it with my patches but have no idea how.

arc patch D13736, but in this case it doesn't have author info.

@chrstphrchvz Can you please send me your full name and e-mail so I can push it for you?

chrstphrchvz added a comment.Jun 27 2018, 1:25 PM

Please use "Christopher Chavez", chrischavez at gmx dot us.

Closed by commit R875:60b7cbd9b6b0: Fix location of Info.plist file for macOS build (authored by chrstphrchvz, committed by drosca). · Explain WhyJun 27 2018, 3:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/main/CMakeLists.txt (2 lines)

Diff 36773

View Options

src/main/CMakeLists.txt

Loading...