[ECMGenerateHeaders] Add option for other header file extension than .h
ClosedPublic
Actions

Authored by kossebau on Jun 25 2018, 4:35 PM.

Details

Reviewers

Commits

R240:5207cdeb2359: [ECMGenerateHeaders] Add option for other header file extension than .h

Summary

Quite some C++-based projects do not use .h as header file extension, but
.hpp, .hxx or other variants. Making the header file extension configurable
enables to make use of ECMGenerateHeaders in such projects.

Test Plan

The added unit test works, existing unit tests work as before.
Also using in project with .hpp files works.

Diff Detail

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Jun 25 2018, 4:35 PM

Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJun 25 2018, 4:35 PM

Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Jun 25 2018, 4:35 PM

Harbormaster completed remote builds in B299: Diff 36642.Jun 25 2018, 4:35 PM

Looks good to me.

This revision is now accepted and ready to land.Jun 26 2018, 12:02 PM

Closed by commit R240:5207cdeb2359: [ECMGenerateHeaders] Add option for other header file extension than .h (authored by kossebau). · Explain WhyJun 26 2018, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		modules/ECMGenerateHeaders.cmake (19 lines)
A	M	tests/ECMGenerateHeadersTest/headtest1.hpp
A	M	tests/ECMGenerateHeadersTest/headtest2.hpp
M		tests/ECMGenerateHeadersTest/run_test.cmake.config (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36642	06fa81a		Jun 25 2018, 4:35 PM	★	★
Diff 2	36699	06fa81a	R240:5207cdeb23599145ffdecf57b17b514a7e368e62	Jun 26 2018, 4:50 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fc099820b52f	52ce9e7596b4	06fa81af7f2e	Friedrich W. H. Kossebau	[ECMGenerateHeaders] Add option for other header file extension than .h (Show More…)	Jun 25 2018, 4:26 PM