.ico files work fine, so we should allow them to be chosen in the custom icon file chooser dialog.
BUG: 233201
FIXED-IN: 5.48
Details
Details
- Reviewers
cfeck - Group Reviewers
Frameworks - Commits
- R302:0131f8afe845: Support choosing .ico files in custom icon file chooser
- Find a .ico file lying around, or turn a .png file into a .ico file using https://convertico.com/
- Typ to apply it to a folder in Dolphin
- You can select the .ico file in the dialog, and when applied, it appears correctly as a custom icon for the folder
Diff Detail
Diff Detail
- Repository
- R302 KIconThemes
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
But does it actually work? Our icon loader removes the extension, and tries to find the icon with a set of known extensions (grep -i xpm in kiconloader.cpp).
Comment Actions
It does actually work; I tried it. The bug reporter also reported that it worked for him too if he manually entered the path to a .ico file.
Comment Actions
I think if you pass a completely custom icon to it an absolute path will be looked up and as a result this (unintentionally) works
Comment Actions
I was thinking if we need general support for .ico files on Windows, but fear a slowdown while lookup of theme icons. But if this works for the special case of full-path icons, we can revisit the issue once/if we get a separate ticket.