Make sure KLineEdit::clearButtonClicked is emitted
ClosedPublic

Authored by aacid on Jun 23 2018, 11:00 AM.

Details

Summary

Even when calling setClearButtonEnabled instead of setClearButtonShown

Recently KLineEdit::setClearButtonShown got deprecated, but that meant
that silently &KLineEdit::clearButtonClicked would not be emitted.

This patch corrects it. It uses quite a bit of internal magic, but
the old one was already using some so i think it's ok, given it even
comes with an autotest that will break when Qt changes its internals

Test Plan

Test passes :)

Diff Detail

Repository
R284 KCompletion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Jun 23 2018, 11:00 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 23 2018, 11:00 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Jun 23 2018, 11:00 AM
broulik accepted this revision.Jun 27 2018, 9:36 AM
This revision is now accepted and ready to land.Jun 27 2018, 9:36 AM
This revision was automatically updated to reflect the committed changes.