don't use temporaries when uneeded
ClosedPublic
Actions

Authored by tcanabrava on Jun 22 2018, 2:17 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Remove unused variable

Compiled, Run. Trash still there.

Use copy ellision

Remove uneeded code

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

tcanabrava requested review of this revision.Jun 22 2018, 2:17 PM

Thanks

This revision is now accepted and ready to land.Jun 23 2018, 11:00 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/panels/panel.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36522	9b2a970		Jun 22 2018, 2:17 PM	★	★
Diff 2	36671	9b2a970	R318:e1ba299b29235f337b9cc415d874e5fe369d60fb	Jun 22 2018, 1:20 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a723e66c2337	d25b4c583e1b	6b72c67b096f	Tomaz Canabrava	Remove uneeded code	Jun 22 2018, 2:03 PM
6b72c67b096f	55ca70cf152f	f5ce8d865b7e	Tomaz Canabrava	Use copy ellision	Jun 22 2018, 1:30 PM
f5ce8d865b7e	46c0b8b5348c	e1ba299b2923	Tomaz Canabrava	Remove unused variable (Show More…)	Jun 22 2018, 1:21 PM
e1ba299b2923	60e27541d1d6	9b2a9704ee81	Tomaz Canabrava	don't use temporaries when uneeded	Jun 22 2018, 1:20 PM