This is mostly a "painting" change that shows the grid for the warp transform instead of the existing points and connection lines.
This is mostly just to better visualize the result. The existing warp tool has a lot of "original" data and points which get in the way a bit with the end transform result appearance
I also limited the subdivide to 2 - 6. That seems like a reasonable limit. It currently get do 0 and 1 which gave odd results.
Did some warping and change the subdivide points. The appearance appears to be ok.
| Lint Skipped |
| Unit Tests Skipped |
Hi, @scottpetrovic!
I do really like the idea of using grid for this transformation, it would simplify using the warp tool a lot. The patch gives the idea of it, and I like how it looks in general. Though the implementations has two major problems:
hi @dkazakov Thanks for the review
I made some changes...
I added an extra enum so the warp transform knows what style is being drawn. It is the warpCalculation enum that keeps track of it.
Hi, @scottpetrovic!
The patch looks and works basically fine. But could you tell me, why you limited the number of subdivisions by 6? I have a feeling that it is a bit too rough for doing any real work... Is it possible to keep the number of subdivisions unlimited as it used to be?
At least with me and one other artist, having any more than 4 the warp tool starts to become less usable. There are so many points it is difficult to do the warping. If a transformation needs to be really smooth with being bent, it is easier to just use the liquefy tool with a large brush size and push it.
Other applications have warp using bezier points on the corner handles to get a similar effect. We would either need that or some type of soft selection to make more points useful. That was my logic for limiting it to 6. I didn't see anyone using 6, but did it on the safe side.
I can ping some other artists to see what they do.
Thank you for the work on Wrap transform.
I understand the limitation to 6 max; I rarely subdivide a lot myself. If I need more thinner grain or smaller deformation: I often prefer the Liquify mode.
But maybe Someone can use it later on a super large canvas with a lot of CPU/GPU, and why not limiting the amount in this case?
I swapped out it so it goes up to 30 subdivisions if someone really wants. I don't know if we need to go up to unlimited. I swapped out the algorithm so it just takes the square root of the points instead of the manual assigning.
30 would be enough I think.
Other applications have warp using bezier points on the corner handles to get a similar effect.
This would be good to have if it is possible
Hi, @scottpetrovic!
The patch looks and works fine now! Please push!
There is still one small bug (not a regression, so you can push without it). The grid lines are now painted with the handles painter, so they are rendered correctly on any zoom levels, but the circular handles are not. Please see the attached screenshot of 8k image. The handles are scaled down too drastically.
To overcome this issue, one should use KisHandlePainterHelper::drawHandleCircle. But three special KisHandleStyle objects will have to be created to describe the fill modes used in the transform tool: unselected, active, multiselect (red).
As far as I can tell, the patch has been committed in a8ca98974df7c96e2ff564797f2e3aa534d194f0, so let's close it :)