Differential D13614

Workaround crash in Aurorae destruction
ClosedPublic
Actions

Authored by davidedmundson on Jun 19 2018, 3:24 PM.

Details

Reviewers
mart
Group Reviewers
KWin
Plasma
Commits
R108:275b7ee0f456: Workaround crash in Aurorae destruction
Summary

Workaround QtBug-68997

Deleting of a RenderControl/render controlled window triggers deletion
of other queued deleted items, putting KWin in a corrupt state. See Qt
bug report.

Deleting this queued means we know we don't have anything else going on
in the stack which should make this somewhat safe.

BUG: 395346

Test Plan

Couldn't reproduce original crash. Based purely on the incomplete backtrace and code reading

Set an Aurorae theme. Closed some windows. Things still worked as before

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jun 19 2018, 3:24 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 19 2018, 3:24 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jun 19 2018, 3:24 PM
mart accepted this revision.Jun 20 2018, 8:35 AM
This revision is now accepted and ready to land.Jun 20 2018, 8:35 AM
davidedmundson added a comment.Jun 20 2018, 8:36 AM

FYI, I put a proper fix in Qt 5.12 which got +2d already \o/

Closed by commit R108:275b7ee0f456: Workaround crash in Aurorae destruction (authored by davidedmundson). · Explain WhyJun 20 2018, 8:41 AM
This revision was automatically updated to reflect the committed changes.
graesslin added a subscriber: graesslin.Jun 24 2018, 6:59 AM

We are getting regression crash reports on X11 (or older Qt) now: https://bugs.kde.org/show_bug.cgi?id=395732 and a bisect report in https://bugs.kde.org/show_bug.cgi?id=395807

davidedmundson added a comment.Jun 24 2018, 9:55 AM

I've seen. Sorry. It depends on the QSGRenderContext used. One hooks in with the GL context which is now out of scope - and my machine was doing something different.
Might be best to just revert as I did a proper (safe!) fix in Qt 5.12 and the original bug was more rare.

graesslin added a comment.Jun 24 2018, 12:46 PM
In D13614#282363, @davidedmundson wrote:

I've seen. Sorry. It depends on the QSGRenderContext used. One hooks in with the GL context which is now out of scope - and my machine was doing something different.
Might be best to just revert as I did a proper (safe!) fix in Qt 5.12 and the original bug was more rare.

It wasn't that rare. I also see it on Wayland when using Aurorae every time when closing a Wayland window (XWayland is fine). But I'm totally fine with waiting for the 5.12 release. Maybe we should disable Aurorae on Wayland if Qt < 5.12

Revision Contents
Changeset List

Diff 36377

View Options

plugins/kdecorations/aurorae/src/aurorae.h

Loading...
View Options

plugins/kdecorations/aurorae/src/aurorae.cpp

Loading...