Differential D13585

Use LIB_SUFFIX for lmdb libdir rather than hardcode lib
Needs ReviewPublic
Actions

Authored by asturmlechner on Jun 17 2018, 9:12 PM.

Details

Reviewers
None
Group Reviewers
Baloo

Diff Detail

Repository
R293 Baloo
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 83
Build 83: arc lint + arc unit
asturmlechner created this revision.Jun 17 2018, 9:12 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 17 2018, 9:12 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
asturmlechner requested review of this revision.Jun 17 2018, 9:12 PM
asturmlechner added a reviewer: Baloo.Jun 17 2018, 9:14 PM

Not convinved it is the best way but it is some way to make it point to the desired multiarch libdir rather than make it choose a random one.

pino added a subscriber: pino.Jun 18 2018, 2:56 AM

Or just drop the two HINTS (for find_path and find_library) altogether, as cmake already looks in standard include/library paths.

asturmlechner added a comment.Jun 18 2018, 5:30 AM

The problem with that is cmake picking the wrong dir (first in order is lib, while it should be e.g. lib64).

pino added a comment.Jun 18 2018, 5:43 AM
In D13585#279400, @asturmlechner wrote:

The problem with that is cmake picking the wrong dir (first in order is lib, while it should be e.g. lib64).

Sure, and that's why I suggested to drop the usage of LMDB_DIR. There is already CMAKE_PREFIX_PATH to specify additional prefixes where to search for installed software, so LMDB_DIR is simply an ad-hoc version of it.
In case this is the chosen way, make sure to port away from where LMDB_DIR is used: https://lxr.kde.org/search?_filestring=&_string=LMDB_DIR

Revision Contents
Changeset List

PathPackages
Mcmake/FindLMDB.cmake (4 lines)

Diff 36262

View Options

cmake/FindLMDB.cmake

Loading...