Differential D13557

Set the scrollbar style transparent background
AbandonedPublic
Actions

Authored by tcanabrava on Jun 15 2018, 9:16 AM.

Details

Reviewers
ngraham
hindenburg
Group Reviewers
Konsole
Summary

This makes the scrollbar to behave nicely
when the user default style is Oxygen or Fusion
as they don't have a translucent background.

Regression: after changing the Profile colors
the background will behave as non-transparent,
after restarting it will work.

Test Plan

Diff Detail

Repository
R319 Konsole
Branch
scrollBarStyle
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 34
Build 34: arc lint + arc unit
tcanabrava created this revision.Jun 15 2018, 9:16 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 15 2018, 9:16 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jun 15 2018, 9:16 AM
tcanabrava edited the test plan for this revision. (Show Details)Jun 15 2018, 9:17 AM
tcanabrava added reviewers: ngraham, hindenburg, Konsole.
hindenburg added a comment.Jun 15 2018, 1:42 PM

It appears this makes the scrollbar wider; was that expected?

src/TerminalDisplay.cpp
356

Not to be pedantic but we typically don't want comments likes this

tcanabrava abandoned this revision.Jun 15 2018, 2:31 PM
In D13557#278750, @hindenburg wrote:

It appears this makes the scrollbar wider; was that expected?

this patch is broken in many ways, sorry for the false positive.
I'm trying a second option right now.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.cpp (39 lines)

Diff 36193

View Options

src/TerminalDisplay.cpp

Loading...