KDevelop plugin: Use kdevplatform_add_plugin macro
ClosedPublic
Actions

Authored by kfunk on Apr 7 2016, 6:28 PM.

Details

Reviewers

giorgos.tsiapaliokas
sebas
rjvbb

Commits

R855:5b0c8fffe967: KDevelop plugin: Use kdevplatform_add_plugin macro
R118:5b0c8fffe967: KDevelop plugin: Use kdevplatform_add_plugin macro

Diff Detail

Repository

R118 Plasma SDK

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kfunk updated this revision to Diff 3200.Apr 7 2016, 6:28 PM

kfunk retitled this revision from to KDevelop plugin: Use kdevplatform_add_plugin macro.

kfunk updated this object.

kfunk edited the test plan for this revision. (Show Details)

kfunk added a reviewer: giorgos.tsiapaliokas.Apr 7 2016, 6:29 PM

kfunk added a project: Plasma.

sebas accepted this revision.Apr 8 2016, 1:05 PM

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Apr 8 2016, 1:05 PM

Closed by commit R118:5b0c8fffe967: KDevelop plugin: Use kdevplatform_add_plugin macro (authored by kfunk). · Explain WhyApr 8 2016, 1:16 PM

This revision was automatically updated to reflect the committed changes.

@rjvbb wants me to backport this to 5.6 -- should we do it?

In D1349#35285, @kfunk wrote:

@rjvbb wants me to backport this to 5.6 -- should we do it?

Didn't say I *want* it, I just asked why it was apparently committed before 5.6 was released (= in April) but isn't in 5.6.5 ...
If 5.6.5 is the last 5.6 release there's little point in backporting, is there!

It's unlikely that the 5.6 branch sees a next release, but if it makes your lives easier, go ahead and merge.

Okay, then I don't see a need to backport. Thanks.

Revision Contents
Changeset List

		Path
M		plasmate/plugins/plasmaprojectmanager/CMakeLists.txt (11 lines)
D	M	plasmate/plugins/plasmaprojectmanager/kdevplasmamanager.desktop.cmake (95 lines)
A	M	plasmate/plugins/plasmaprojectmanager/kdevplasmamanager.json (102 lines)