Differential D13438

Removed obsolete PackagePath role from AppletModel
ClosedPublic
Actions

Authored by malteveerman on Jun 8 2018, 10:55 PM.

Details

Reviewers
heikobecker
Group Reviewers
Amarok
Commits
R181:cc57275e701c: Removed obsolete PackagePath role from AppletModel
Summary

This removes the old PackagePath role from AppletModel and improves SvgHandler to handle qrc urls.

Diff Detail

Repository
R181 Amarok
Branch
context
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17969
Build 17987: arc lint + arc unit
malteveerman created this revision.Jun 8 2018, 10:55 PM
Restricted Application removed a project: Amarok. · View Herald TranscriptJun 8 2018, 10:55 PM
Restricted Application added a subscriber: amarok-devel. · View Herald Transcript
malteveerman requested review of this revision.Jun 8 2018, 10:55 PM
malteveerman updated this revision to Diff 36046.Jun 12 2018, 1:50 PM

Fixed some issues with newer kf5 and qt versions.

malteveerman updated this revision to Diff 68430.Oct 21 2019, 12:56 PM
  • Made SvgHandler handle QRC resource files.
  • Removed "PackagePath" data role from AppletModel.
  • Moved applet view from ListView to Flickable.
  • Made applet loading synchronous.
  • Fixed qrc resource url handling.
  • Restricted context flicking to vertical direction.

Rebased against current master

Restricted Application added a project: Documentation. · View Herald TranscriptOct 21 2019, 12:56 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
heikobecker requested changes to this revision.Feb 21 2020, 4:38 PM
heikobecker added a subscriber: heikobecker.

I'm sorry for stepping in soo late, but this has really become too huge to review and does multiple things at once. Could you please split it up? I'll push an older diff, without the unrelated changes, which were added later.

This revision now requires changes to proceed.Feb 21 2020, 4:38 PM
This revision was not accepted when it landed; it landed in state Needs Revision.Feb 21 2020, 4:42 PM
Closed by commit R181:cc57275e701c: Removed obsolete PackagePath role from AppletModel (authored by malteveerman, committed by heikobecker). · Explain Why
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1358614ae365fJun 8 2018, 10:52 PM
★
★
Diff 2360464ae365fJun 12 2018, 1:48 PM
★
★
Diff 368430c9257ad - Made SvgHandler handle QRC resource files.Oct 21 2019, 12:56 PM
★
★
Diff 47611856f1a5eR181:cc57275e701c4b4795da3eeed69818e01f416255Feb 21 2020, 3:59 PM
★
★
This very large diff affects more than 1,000 files. Use the Changeset List to browse changes.