Removed obsolete PackagePath role from AppletModel
ClosedPublic

Authored by malteveerman on Jun 8 2018, 10:55 PM.

Details

Summary

This removes the old PackagePath role from AppletModel and improves SvgHandler to handle qrc urls.

Diff Detail

Repository
R181 Amarok
Branch
context
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17969
Build 17987: arc lint + arc unit
malteveerman created this revision.Jun 8 2018, 10:55 PM
Restricted Application removed a project: Amarok. · View Herald TranscriptJun 8 2018, 10:55 PM
Restricted Application added a subscriber: amarok-devel. · View Herald Transcript
malteveerman requested review of this revision.Jun 8 2018, 10:55 PM

Fixed some issues with newer kf5 and qt versions.

  • Made SvgHandler handle QRC resource files.
  • Removed "PackagePath" data role from AppletModel.
  • Moved applet view from ListView to Flickable.
  • Made applet loading synchronous.
  • Fixed qrc resource url handling.
  • Restricted context flicking to vertical direction.

Rebased against current master

Restricted Application added a project: Documentation. · View Herald TranscriptOct 21 2019, 12:56 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
heikobecker requested changes to this revision.Feb 21 2020, 4:38 PM
heikobecker added a subscriber: heikobecker.

I'm sorry for stepping in soo late, but this has really become too huge to review and does multiple things at once. Could you please split it up? I'll push an older diff, without the unrelated changes, which were added later.

This revision now requires changes to proceed.Feb 21 2020, 4:38 PM
This revision was not accepted when it landed; it landed in state Needs Revision.Feb 21 2020, 4:42 PM
This revision was automatically updated to reflect the committed changes.