Show number of incomplete (fuzzy + untranslated) strings in project view
ClosedPublic

Authored by huftis on Jun 7 2018, 5:26 PM.

Details

Summary

This adds a new column, ‘Incomplete’ to the project view. This
shows the number of entries that are *either* fuzzy (‘not ready’)
or untranslated.

A use case might be someone updating a module/package which is *mostly*
translated, but which have seen some changes lately, with many files
with a *few* untranslated/fuzzy strings each (‘kde-workspace’ is a
typical example). The translators wants to quickly find which files
need updating. Sorting by the ‘Not ready’ column misses the files
with only *new* (‘Untranslated’ strings). Sorting by the ‘Untranslated’
column misses the files with only fuzzy (‘Not ready’) strings. So
before this patch, the translator needed to resort the list of files
twice (or actually four times, since clicking on a column first sorts
the list in ascending order, i.e. with the fully translated files first).
With the patch, the translator can easily sort the list so that it shows
*all* the files which need updating at the top, which makes their
work easier. :)

Test Plan
  • Open project view before and after patch.
  • Notice new ‘Incomplete’ column.
  • Sort the list of files by the ‘Incomplete’ column and check that it works.
  • Check that the number in the ‘Incomplete’ column is the sum of the numbers in the ‘Not ready’ and ‘Untranslated’ columns.

Diff Detail

Repository
R456 Lokalize
Branch
show-incomplete (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
huftis requested review of this revision.Jun 7 2018, 5:26 PM
huftis created this revision.
huftis added a comment.Jun 7 2018, 5:28 PM

Before patch:

After patch:

huftis added a comment.Jun 7 2018, 5:34 PM

I was struggling with what to call this column. I thought the most natural name would be ‘Not ready’, but unfortunately ‘fuzzy’ strings are now called ‘Not ready’ in Lokalize (for some reason), so that name is already taken. I ended up calling it ‘Incomplete’, as it shows which strings need to be completed.

Note that this patch adds a new string to translate. I will ask for an exception to the string freeze on the kde-i18n-doc before committing. (I don’t think this will be a problem, as Lokalize is an application that’s used only by the translators.)

aacid added a comment.Jun 7 2018, 9:27 PM

You can't add new features to a stable branch

huftis updated this revision to Diff 35818.Jun 8 2018, 5:03 AM
huftis edited the summary of this revision. (Show Details)

I’ve now (hopefully) changed this to land on master
instead of stable.

This comment was removed by adrianchavesfernandez.
aacid accepted this revision.Jun 8 2018, 6:22 PM

I'm not convinced "Incomplete" is the best name, but people will understand what it means quickly so i think this can go in.

Maybe give it a few days before pushing in case someone objects or finds a better name for Incomplete.

This revision is now accepted and ready to land.Jun 8 2018, 6:22 PM
huftis added a comment.EditedJun 8 2018, 6:40 PM

Maybe give it a few days before pushing in case someone objects or finds a better name for Incomplete.

OK. I’ll wait a few days.

BTW, I discovered yesterday that posieve stats also uses the word ‘incomplete’ for what I presume is the same feature:

incomplete [flag]
    List catalogs which are not fully translated, with incompletness
huftis closed this revision.Jun 11 2018, 6:25 PM

Closed by https://commits.kde.org/lokalize/c1fd23b55999974e50cfda299c55753796f81f31. (I don’t know why arc land didn’t close this automatically.)