Differential D13397

Support desktop:/ protocol
ClosedPublic
Actions

Authored by broulik on Jun 7 2018, 5:51 AM.

Tags

None

Subscribers

None

Details

Reviewers

dfaure
jriddell
gregormi

Commits

R432:abf945afd4f0: Support desktop:/ protocol

Summary

This is a local folder as well. Use KFileItem::mostLocalUrl() instead of the property dialog's URL

BUG: 394316

Test Plan

Compiles, dialog shows up for folders on desktop now.
Didn't do any further testing, please do.
Also, the "is shared" badge doesn't show up on desktop but that is probably also caused by the rewrite of local URL to desktop:/ URL and then it doesn't match

Diff Detail

Repository

R432 File Sharing (Samba) integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik requested review of this revision.Jun 7 2018, 5:51 AM

broulik created this revision.

broulik mentioned this in D13398: [KFileItem] Check most local URL for whether it's shared.Jun 7 2018, 5:58 AM

dfaure accepted this revision.Jun 13 2018, 7:56 AM

This revision is now accepted and ready to land.Jun 13 2018, 7:56 AM

Closed by commit R432:abf945afd4f0: Support desktop:/ protocol (authored by broulik). · Explain WhyJul 2 2018, 7:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			samba/filepropertiesplugin/sambausershareplugin.cpp (2 lines)
M			samba/filepropertiesplugin/sambausershareplugin.desktop (1 line)

Diff 37026

samba/filepropertiesplugin/sambausershareplugin.cpp

Loading...

samba/filepropertiesplugin/sambausershareplugin.desktop

Loading...