If QT_NO_CAST_FROM_BYTEARRAY is set, along with using MDNSRESPONDER,
then the implicit cast from QByteArray to const char * is not available.
The MDNSRESPONDER API uses const char * parameters and kdnssd passes
QByteArray to them. Make the necessary conversion explicit.
Submitted downstream in FreeBSD by Ashish SHUKLA
| No Linters Available |
| No Unit Test Coverage |
-DQT_NO_CAST_FROM_BYTEARRAY is a default define from KDEFrameworkCompilerSettings.cmake, so kdnssd should be working. The reason it wasn't is likely because most/all distributions build with avahi. Additionally, build.kde.org seems to build without avahi and dnssd, so it doesn't validate half the code at all 😒
With all that said, the change looks good.
qUtf8Printable might be nicer to read than qString.toUtf8().constData() though, might be worth thinking about.
| src/mdnsd-publicservice.cpp | ||
|---|---|---|
| 163 | Is there a reason the second call is going to data() rather than constData()? There is const char *data() const so it ultimately makes no difference, for code expressiveness I would say all calls should be to constData() though. | |