fix for macOS
ClosedPublic

Authored by yurikoles on Sep 13 2018, 1:37 PM.

Diff Detail

Repository
R272 KDNSSD
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurikoles created this revision.Sep 13 2018, 1:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 13 2018, 1:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
yurikoles requested review of this revision.Sep 13 2018, 1:37 PM

Author is:

Hessel van der Molen <hmolen.science@gmail.com>

Copyright confirmed in comment to commit in kde-mac/kde homebrew tap.

arichardson accepted this revision.Sep 13 2018, 1:57 PM
arichardson added a subscriber: arichardson.

I can confirm that this fixes the build for me.

This revision is now accepted and ready to land.Sep 13 2018, 1:57 PM

Does this still build on Linux systems?

Does this still build on Linux systems?

I have problems building it under Linux even without a patch. I had tried Arch AUR (kdnssd-git) and Ubuntu 18.10 (cosmic), which has kdnssd-kf5-5.50.0 in archive.

Error: Input /home/yurikoles/kdnssd-kf5-5.50.0/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml is not a file or cannot be accessed

Error: Input /home/yurikoles/kdnssd-kf5-5.50.0/src/org.freedesktop.Avahi.ServiceBrowser.xml is not a file or cannot be accessed

Error: Input /home/yurikoles/kdnssd-kf5-5.50.0/src/org.freedesktop.Avahi.DomainBrowser.xml is not a file or cannot be accessed

make[3]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:91: src/avahi_servicetypebrowser_interface.cpp] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:69: src/avahi_domainbrowser_interface.cpp] Error 1
make[3]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:80: src/avahi_servicebrowser_interface.cpp] Error 1
make[3]: Leaving directory '/home/yurikoles/kdnssd-kf5-5.50.0/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:3996: src/CMakeFiles/KF5DNSSD.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
qt.qpa.plugin: Could not find the Qt platform plugin "minimal" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)
make[3]: Leaving directory '/home/yurikoles/kdnssd-kf5-5.50.0/obj-x86_64-linux-gnu'
[ 84%] Built target KF5DNSSD_QCH
make[2]: Leaving directory '/home/yurikoles/kdnssd-kf5-5.50.0/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:144: all] Error 2
make[1]: Leaving directory '/home/yurikoles/kdnssd-kf5-5.50.0/obj-x86_64-linux-gnu'
dh_auto_build: cd obj-x86_64-linux-gnu && make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:7: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
debuild: fatal error at line 1152:
dpkg-buildpackage -rfakeroot -us -uc -ui -b failed

Okay. That's quite an unusual error as that should work.

We'll have to let the CI system confirm this one. Please go ahead and commit.

Okay. That's quite an unusual error as that should work.

We'll have to let the CI system confirm this one. Please go ahead and commit.

I have no rights.

Closed by commit R272:4eb0a90c7dd9: fix for macOS (authored by Hessel van der Molen <hmolen.science@gmail.com>, committed by vonreth). · Explain WhyNov 13 2018, 9:17 AM
This revision was automatically updated to reflect the committed changes.
apol added a subscriber: apol.Nov 13 2018, 1:42 PM

Then please don't fork our own projects.