Differential D13299

Hide decoration tooltip when the decoration gets destroyed
ClosedPublic
Actions

Authored by graesslin on Jun 3 2018, 11:31 AM.

Details

Reviewers
romangg
Group Reviewers
KWin
Plasma
Commits
R108:c44adda40f47: Hide decoration tooltip when the decoration gets destroyed
Summary

BUG: 394977
FIXED-IN: 5.13.0

Test Plan

Untested as my system decides to crash everything

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Jun 3 2018, 11:31 AM
Restricted Application added a project: KWin. · View Herald TranscriptJun 3 2018, 11:31 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Jun 3 2018, 11:31 AM
zzag added a subscriber: zzag.Jun 3 2018, 1:13 PM

Untested as my system decides to crash everything

I've tested it. Seems to be working.

graesslin updated this revision to Diff 35468.Jun 3 2018, 5:28 PM

Figured out why everything is crashing and could test now.

romangg accepted this revision.Jun 4 2018, 1:47 PM
romangg added a subscriber: romangg.

Do you need the m_toolTipShowing variable at all? On destruct just always calling requestHideToolTip should be possible, not?

This revision is now accepted and ready to land.Jun 4 2018, 1:47 PM
graesslin added a comment.Jun 4 2018, 3:04 PM
In D13299#273653, @romangg wrote:

Do you need the m_toolTipShowing variable at all? On destruct just always calling requestHideToolTip should be possible, not?

Yes, but it would close even tooltips shown on other windows.

romangg added a comment.Jun 4 2018, 3:27 PM

Right, because it's a single tooltip instance for KWin and not per client. Ok, then let's land it like it is.

Closed by commit R108:c44adda40f47: Hide decoration tooltip when the decoration gets destroyed (authored by graesslin). · Explain WhyJun 10 2018, 7:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35935

View Options

decorations/decoratedclient.h

Loading...
View Options

decorations/decoratedclient.cpp

Loading...