[server] Send frame event instead of flush on relative pointer motion
ClosedPublic
Actions

Authored by romangg on May 31 2018, 10:48 PM.

Details

Reviewers

Group Reviewers

Plasma
KWin
Frameworks

Maniphest Tasks

T8923: Improve cursor locking and confining

Commits

R127:5e195c2a67ce: [server] Send frame event instead of flush on relative pointer motion

Summary

This solves for me not working relative pointer motion with grab/lock in
Xwayland applications.

Looking at the Xwayland code it is clear, that it expects a frame event on
wl_pointer versions 5 and above after relative motion events. wl_pointer
version 5 support was added to KWayland in b6bd28ab.

If the cursor is locked no absolute motion events are sent. In this case to
make sure relative motion events are processed by the client, send the frame
event after every relative motion.

BUG: 395815

Test Plan

Manually with Neverball in Xwayland mode.

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.May 31 2018, 10:48 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMay 31 2018, 10:48 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

romangg requested review of this revision.May 31 2018, 10:48 PM

romangg mentioned this in T8923: Improve cursor locking and confining.May 31 2018, 10:49 PM

romangg added a task: T8923: Improve cursor locking and confining.

ping

You're matching the buttonReleased/buttonPressed/axis/etc events. So +2 for the immediate fix.

But longterm the point of sendFrame is to help batching so the current code of calling sendFrame in every send event is wrong and undermines the wayland design.
IMHO it needs to be either explicit from kwin, or alternatively some clever code here that only actually calls sendFrame once when we hit the event loop.

This revision is now accepted and ready to land.Jun 25 2018, 11:00 AM

romangg edited the summary of this revision. (Show Details)Jun 25 2018, 6:03 PM

Correct, in the end we want to combine input events and send them batched. For now the KWayland code does not allow this in general.

Closed by commit R127:5e195c2a67ce: [server] Send frame event instead of flush on relative pointer motion (authored by romangg). · Explain WhyJun 26 2018, 3:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/server/pointer_interface.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	35293	d3a29d6		May 31 2018, 10:48 PM	★	★
Diff 2	36691	64ce88d	R127:5e195c2a67ce520803f8936160c5e61d431dcbac	Jun 26 2018, 2:35 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3f42274d36f4	8cc4bac7180d	d3a29d6babc3	Roman Gilg	[server] Send frame event instead of flush on relative pointer motion (Show More…)	May 31 2018, 10:28 PM

Diff 36691

View Options

src/server/pointer_interface.cpp